Modify MsgSendTx fields based on audit #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
seantking,
colin-axner,
AdityaSripal,
damiannolan,
crodriguezvega and
charleenfei
as code owners
chatton
commented
Sep 13, 2022
| @@ -50,7 +50,7 @@ func (s msgServer) SendTx(goCtx context.Context, msg *types.MsgSendTx) (*types.M | |||
| } | |||
|
|
|||
| // explicitly passing nil as the argument is discarded as the channel capability is retrieved in SendTx. | |||
| seq, err := s.Keeper.SendTx(ctx, nil, msg.ConnectionId, portID, msg.PacketData, msg.TimeoutTimestamp) | |||
| seq, err := s.Keeper.SendTx(ctx, nil, msg.ConnectionId, portID, msg.PacketData, msg.RelativeTimeout) | |||
There was a problem hiding this comment.
this value will be passed correctly in #2257
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2280 +/- ##
==========================================
+ Coverage 79.54% 79.57% +0.03%
==========================================
Files 175 175
Lines 12069 12118 +49
==========================================
+ Hits 9600 9643 +43
- Misses 2045 2049 +4
- Partials 424 426 +2
|
colin-axner
reviewed
Sep 20, 2022
…hub.com/cosmos/ibc-go into cian/issue#2232-modify-msgsendtx-fields
3 tasks
colin-axner
reviewed
Sep 21, 2022
damiannolan
approved these changes
Sep 26, 2022
colin-axner
reviewed
Sep 26, 2022
| flagPacketTimeoutHeight = "packet-timeout-height" | ||
| flagPacketTimeoutTimestamp = "packet-timeout-timestamp" | ||
| flagVersion = "version" | ||
| flagRelativePacketTimeoutTimestamp = "relative-packet-timeout" |
There was a problem hiding this comment.
Nit: why not drop the Timestamp word? In the proto file is called just relative_timeout and timestamp has the connotation of a fixed date/time...
There was a problem hiding this comment.
it must have been accidentally included! I've removed it now
colin-axner
reviewed
Sep 28, 2022
Comment on lines
40
to
41
| // Timeout timestamp in absolute nanoseconds since unix epoch. | ||
| // The timeout is disabled when set to 0. |
There was a problem hiding this comment.
Looks like the documentation needs to be moved and updated.
I'd suggest:
Suggested change
| // Timeout timestamp in absolute nanoseconds since unix epoch. | |
| // The timeout is disabled when set to 0. | |
| // Relative timeout timestamp provided will be added to the current block time during transaction execution. | |
| // The timeout timestamp must be non-zero. |
This will close #2267
colin-axner
approved these changes
Sep 28, 2022
Co-authored-by: colin axnér <[email protected]>
…hub.com/cosmos/ibc-go into cian/issue#2232-modify-msgsendtx-fields
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2022
(cherry picked from commit 3c21b5e)
colin-axner
pushed a commit
that referenced
this pull request
Sep 29, 2022
(cherry picked from commit 3c21b5e) Co-authored-by: Cian Hatton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #2232
closes: #2200
closes: #2267
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes